Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dune to generate OPAM package definitions #1191

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

dhil
Copy link
Member

@dhil dhil commented Nov 15, 2023

This patch moves the definitions of our OPAM packages into the file dune-project. The OPAM package definitions are automatically generated from this file. This approach offers some advantages:

  • Less redundancy: package descriptions are now shared.
  • Dune integration: OPAM package definitions are kept in sync with dune.
  • Versioning: dune-release automatically versions the OPAM package definitions.

Our build rules for the links package are a little more complicated than dune supports out-of-the-box. The steps required to build this package are defined in the links.opam.template file, which dune automatically pastes into the generated links.opam file.

@dhil dhil requested a review from frank-emrich November 15, 2023 11:13
@dhil
Copy link
Member Author

dhil commented Nov 15, 2023

I fixed the minimum required version of OCaml to 4.14.0, as that seems to be the minimum version with which Links compiles at the moment.

@dhil dhil requested review from jamescheney, slindley, SimonJF, thwfhk, vcgalpin and wricciot and removed request for vcgalpin November 15, 2023 11:15
@dhil dhil force-pushed the generate-opam branch 2 times, most recently from 4b67ec3 to 70bfc8c Compare November 16, 2023 14:31
@dhil dhil merged commit 11652c2 into links-lang:master Nov 27, 2023
9 checks passed
@dhil dhil deleted the generate-opam branch November 27, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant