Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phase #60

Open
wants to merge 1 commit into
base: 7.x-4.x
Choose a base branch
from
Open

fix phase #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ nbproject
/sites/default/_settings.php
/profiles/openideal/sublime-openideal.sublime-project
/profiles/openideal/sublime-openideal.sublime-workspace
/.gitk-tmp.11456/
/.gitk-tmp.11456/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@israelLinnovate @nevos Can you make this more generic? (for example .gitk-tmp*)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although it's not at all relevant to the PR..

.idea/
4 changes: 3 additions & 1 deletion modules/custom/ideal_blocks/ideal_blocks.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ function _ideal_blocks_idea_stats() {

// Hardcode phase for now.
$phase = t('Phase');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a default Phase, probably through the field's configuration.
For now, change the initial value to "Ideation"
@israelLinnovate


if (!empty($entity->field_in_action)){
$phase = $entity->field_in_action["und"][0]["value"];
Copy link
Member

@zohar zohar Sep 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this string is safe (escaped as necessary)
@Israel123

}
// Generate output.
$output = '<div id="ideal-challenge-stats">';
$output .= '<table class="top idea-page"><tr>';
Expand Down