-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom resource config for teams #1776
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the defaults.
The testing worked. Could change the resources through the values for for team apps and tekton tasks ✅
@@ -13,12 +15,16 @@ metadata: | |||
spec: | |||
stepTemplate: | |||
computeResources: | |||
{{- if $custom }} | |||
{{- $v.resources.gitcloneTask.resources | toYaml | nindent 6 }} | |||
{{- else }} | |||
limits: | |||
cpu: "2" | |||
memory: 2Gi | |||
requests: | |||
cpu: 500m | |||
memory: 512Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe want to set these defaults lower? I think its pretty high for a simple git-clone task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because we want to provide a good initial user experience
This PR offers the ability (if required) to adjust the resource configuration of Tekton Tasks, Grafana, Tekton Dashboard and Alertmanager. Summary:
Adjustments can be made by adding:
Checklist
adr/*.md
and appended to list inadr/_index.md
, if applicable.values-schema.yaml
file andtest/**
fixtures have been updated to reflect code changes, if applicable.values-schema.yaml
file, if applicable.