Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom resource config for teams #1776

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: custom resource config for teams #1776

wants to merge 3 commits into from

Conversation

srodenhuis
Copy link
Contributor

This PR offers the ability (if required) to adjust the resource configuration of Tekton Tasks, Grafana, Tekton Dashboard and Alertmanager. Summary:

  • no resource defaults in teamConfig
  • no changes in apl-api
  • platform-admin can add resource customizations directly in values repo
  • only for edge cases where the defaults are not sufficient

Adjustments can be made by adding:

teamConfig:
    demo:
        resources:
            alertmanager:
                enabled: true
                resources:
                    limits:
                        cpu: "5"
                        memory: 5Gi
                    requests:
                        cpu: 5m
                        memory: 5Mi

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/apl-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@srodenhuis srodenhuis marked this pull request as draft October 25, 2024 14:00
@CasLubbers CasLubbers self-requested a review October 28, 2024 09:04
@srodenhuis srodenhuis marked this pull request as ready for review October 29, 2024 09:56
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the defaults.
The testing worked. Could change the resources through the values for for team apps and tekton tasks ✅

@@ -13,12 +15,16 @@ metadata:
spec:
stepTemplate:
computeResources:
{{- if $custom }}
{{- $v.resources.gitcloneTask.resources | toYaml | nindent 6 }}
{{- else }}
limits:
cpu: "2"
memory: 2Gi
requests:
cpu: 500m
memory: 512Mi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we maybe want to set these defaults lower? I think its pretty high for a simple git-clone task

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because we want to provide a good initial user experience

values-schema.yaml Outdated Show resolved Hide resolved
@srodenhuis srodenhuis marked this pull request as draft October 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants