Skip to content

Configurable DB Params: Add test coverage for nullable fields #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proj/configurable-db-params
Choose a base branch
from

Conversation

ykim-akamai
Copy link
Contributor

📝 Description

Add test coverage for nullable field:

  • MySQL: innodb_ft_server_stopword_table
  • PostgreSQL: None

Password Encryption in PG DB will default to "md5" when nothing or null value is specified

✔️ How to Test

╰─➤  make test-int TEST_CASE=test_create_postgres_db_password_encryption_default_md5 RUN_DB_TESTS=yes
╰─➤  make test-int TEST_CASE=test_create_mysql_db_nullable_field RUN_DB_TESTS=yes 

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner May 6, 2025 22:16
@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label May 6, 2025
@ykim-akamai ykim-akamai requested review from jriddle-linode, yec-akamai and ezilber-akamai and removed request for a team May 6, 2025 22:16
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this! Tests are passing locally.

@lgarber-akamai lgarber-akamai self-requested a review May 9, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants