Skip to content

fix: Add / prefix to path in mysql_config_options(...) and postgresql_config_options(...) API calls #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: proj/configurable-db-params
Choose a base branch
from

Conversation

lgarber-akamai
Copy link
Contributor

📝 Description

This pull request adds a / prefix to the API request paths in the DatabaseGroup(...).mysql_config_options(...) and DatabaseGroup(...).postgresql_config_options(...), which resolves the following error that occurs when attempting to call these methods from an external consumer:

Failed to get Configuration with Database Engine mysql: GET /v4betadatabases/mysql/config: [404] Not found

✔️ How to Test

The following test steps assume you have pulled down this PR locally and run make install.

Unit Testing

make test-unit

Integration Testing

make test-int TEST_COMMAND=models/database/test_database_engine_config.py RUN_DB_TESTS=true

@lgarber-akamai lgarber-akamai added the bugfix for any bug fixes in the changelog. label May 7, 2025
@lgarber-akamai lgarber-akamai requested a review from a team as a code owner May 7, 2025 14:59
@lgarber-akamai lgarber-akamai requested review from jriddle-linode, yec-akamai and ezilber-akamai and removed request for a team and jriddle-linode May 7, 2025 14:59
@lgarber-akamai lgarber-akamai changed the title fix:Add / prefix to path in mysql_config_options(...) and postgresql_config_options(...) API calls fix: Add / prefix to path in mysql_config_options(...) and postgresql_config_options(...) API calls May 7, 2025
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants