Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-lxatac-software: python3-labgrid: upgrade to version using grpc #182

Closed
wants to merge 3 commits into from

Conversation

hnez
Copy link
Member

@hnez hnez commented Sep 19, 2024

This marks a breaking change compared to the previous release version, as master now uses grpc instead of crossbar to communicate between the client, coordinator and exporters.

This means all of these components need to be updated to the grpc-based versions at the same time.

See labgrid-project/labgrid#1469 for more information about this change.

Once we have tested these changes in meta-lxatac they should be moved to meta-labgrid.

TODO before merging:

  • Get Signed-Off-By's from @jluebbe since these changes were initially authored by him on an internal meta-lxatac customization layer.
  • Make sure the exporter works with other grpc based coordinators.

@hnez hnez requested a review from jluebbe September 19, 2024 07:04
@hnez hnez assigned hnez and jluebbe Sep 19, 2024
@hnez hnez removed their assignment Sep 27, 2024
@hnez
Copy link
Member Author

hnez commented Oct 11, 2024

Hi @jluebbe, how should we go forward with this?

…reflection

These are required by the new grpc-based labgrid versions.
This marks a breaking change compared to the previous release version,
as master now uses grpc instead of crossbar to communicate between the
client, coordinator and exporters.

This means all of these components need to be updated to the grpc-based
versions at the same time.

Signed-off-by: Leonard Göhrs <[email protected]>
@hnez
Copy link
Member Author

hnez commented Oct 18, 2024

Hi @jluebbe, should we go forward with this PR or e.g. go via meta-labgrid instead?

@jluebbe
Copy link
Member

jluebbe commented Oct 21, 2024

This should go to meta-labgrid, as we already have the LABGRID_USE_DEVEL_VERSION switch there that we can use.

@jluebbe
Copy link
Member

jluebbe commented Oct 21, 2024

I've merged the required recipes in meta-labgrid:
labgrid-project/meta-labgrid#58

@jluebbe jluebbe closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants