Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: downgrade dependencies by checking out an old version #78

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Sep 9, 2024

The upgraded dependencies have exposed an issue in the way package names are handled in the bitbake npm package fetcher.
The issue being that the names '@types/ramda' and 'types-ramda' are mangled into the same name, which results in their tar archives being called the same if the versions match as well, resulting in one overwriting the other.
There is a fix for this, which made it into poky master but not into scarthgap (yet).

Getting it into scarthgap is the ultimate goal, but right now it is holding us back from rolling a new release.

Undo the the dependency updates for now, so we can roll a new meta-lxatac release. We can re-do the updates once the fix is backported to scarthgap.

This resets the package-lock.json to how it was before commit cee818c ("tacd: update dependencies via cargo update").
In this package-lock.json the '@types/ramda' and 'types-ramda' packages have different version numbers, which means the tar archives have different names.

@hnez hnez requested a review from KarlK90 September 9, 2024 09:39
The upgraded dependencies have exposed an issue in the way package names
are handled in the bitbake npm package fetcher.
The issue being that the names '@types/ramda' and 'types-ramda' are
mangled into the same name, which results in their tar archives being
called the same if the versions match as well,
resulting in one overwriting the other.
There is a fix for this, which made it into poky master[1] but not into
scarthgap (yet).

Getting it into scarthgap is the ultimate goal, but right now it is
holding us back from rolling a new release.

Undo the the dependency updates for now, so we can roll a new meta-lxatac
release. We can re-do the updates once the fix is backported to scarthgap.

This resets the package-lock.json to how it was before commit cee818c
("tacd: update dependencies via cargo update").
In this package-lock.json the '@types/ramda' and 'types-ramda' packages
have different version numbers, which means the tar archives have
different names.

[1]: yoctoproject/poky@ee6bf28

Signed-off-by: Leonard Göhrs <[email protected]>
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnez hnez merged commit 663855c into linux-automation:main Sep 9, 2024
5 checks passed
@hnez hnez deleted the web-downgrade branch September 9, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants