Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tacd: update dependencies via cargo update #81

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

hnez
Copy link
Member

@hnez hnez commented Oct 11, 2024

A routine update inspired by #80. It does not get rid of the security advisory though.

@hnez hnez requested a review from KarlK90 October 11, 2024 14:09
@hnez hnez force-pushed the cargo-update-2024-10-11 branch from bf68f2a to b245e39 Compare October 18, 2024 06:18
@Emantor
Copy link
Member

Emantor commented Oct 22, 2024

We gain windows-sys which according to the crate information is used for Windows APIs. We don't have those, so I suspect this can be disabled through explicit feature specification.

@hnez
Copy link
Member Author

hnez commented Oct 22, 2024

We gain windows-sys

*yet another version of windows-sys:

tacd/Cargo.lock

Lines 3151 to 3176 in b245e39

[[package]]
name = "windows-sys"
version = "0.48.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "677d2418bec65e3338edb076e806bc1ec15693c5d0104683f2efe857f61056a9"
dependencies = [
"windows-targets 0.48.5",
]
[[package]]
name = "windows-sys"
version = "0.52.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "282be5f36a8ce781fad8c8ae18fa3f9beff57ec1b52cb3de0789201425d9a33d"
dependencies = [
"windows-targets 0.52.6",
]
[[package]]
name = "windows-sys"
version = "0.59.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1e38bc4d79ed67fd075bcc251a1c39b32a1776bbe92e5bef1f0bf1f8c531853b"
dependencies = [
"windows-targets 0.52.6",
]

As far as I can tell the Cargo.lock lists the hashes of any package that may be used in any possible build scenario.
I do not know if feature flags set in the Cargo.tomlaffect it that much.

I think most important for us is that none of the windows-sys versions listed in the Cargo.lock are actually compiled when the tacd is built.

@Emantor
Copy link
Member

Emantor commented Oct 23, 2024

Ah, TIL. Apparently Cargo.lock always contains all build deps so it stays consistent across platforms which makes sense to me.

@hnez hnez mentioned this pull request Nov 15, 2024
1 task
@hnez
Copy link
Member Author

hnez commented Nov 22, 2024

Hi @Emantor, now that the windows-sys questions are resolved, could you give this an approval?
I already have the next set of updates in the pipeline with #84.

@hnez hnez force-pushed the cargo-update-2024-10-11 branch from b245e39 to ba64839 Compare December 12, 2024 06:59
@hnez
Copy link
Member Author

hnez commented Dec 12, 2024

I was about to just merge this myself, but it turns out I do not have permissions to do that.
Soo @KarlK90 or @Emantor, can I get an approval please?

@hnez hnez merged commit af6fa45 into linux-automation:main Dec 12, 2024
10 of 11 checks passed
@hnez hnez deleted the cargo-update-2024-10-11 branch December 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants