CANXL support for ASC conversion tools #573
Conversation
|
Please don't forget to send e64d45b to the linux-can ML. |
|
Yes, it is already here: But the process for the CAN XL bitrate setting is currently stuck as there was no feedback from Vincent. If you agree that Edit: I can also send the changes for can.h and we leave the referenced |
|
Yes, please send a patch adding this bit (+ comment update) only. Let's decide later on if we need |
Ok, I will send a patch only focusing on can.h and on |
Signed-off-by: Oliver Hartkopp <[email protected]>
TxRq messages are internal measurement messages that document the time of a transmission request (to the CAN driver) to be checked against the real transmission time, when the CAN message has been sent. There is no such feature in the SocketCAN log format, so we detect this tag but skip TxRq messages in the ASC log files. Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
The Remote Request Substitution bit is a dominant bit ("0") in the CAN XL
frame. As some CAN XL controllers support to access this bit a new
CANXL_RRS value has been defined for the canxl_frame.flags element.
Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
Since using the %n feature the tmp1 buffer is only used for the handling of the CAN identifier. So this buffer can be shrinked for that use case. Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Oliver Hartkopp <[email protected]>
The ASC file provides an information whether the CAN frame is sent (Tx) or received (Rx) on the local CAN node. With the new '-d' option the generation of this information is disabled for the log file generation to simplify the comparision of log files. E.g. log1 -> asc -> log2 always created the T/R information in the log2 file which is then hard to compare to the log1 file which might not have the T/R information at all. Signed-off-by: Oliver Hartkopp <[email protected]>
hartkopp
force-pushed
the
canxl-asc-conversion
branch
from
a8994a0 to
008f9f8
Compare
|
The can.h patch has already been sent to the Linux CAN ML: |
With the documentation which comes with the CANalyser 18SP3 Demo version the tools log2asc and asc2log were made CAN XL capable.
While testing with CANalyser 18SP3 a bug in the ASC file generation was found (CAN CC frames with zero data length) which is announced to be fixed in CANalyser 18SP4 and the new CANalyser 19 in April 2025.