bugfix: stray error 'error: expected declaration specifiers or ‘...’ … #113
Conversation
…before string constant' Signed-off-by: Mrigendra Chaubey <[email protected]>
|
make build fails on 4.15.0-47-generic ubuntu16.04 LTS. |
| @@ -1,6 +1,5 @@ | |||
| #include <linux/init.h> | |||
| #include <linux/kernel.h> | |||
| /* TODO: add missing kernel headers */ | |||
| #include <linux/module.h> | |||
There was a problem hiding this comment.
Are you sure this is the correct fix? We intentionally added the TODO there. This exercises shows the reader what happens if the proper headers are not included.
Thanks for the contribution! But I think you should rethink your solution. If there is a stray character before the comment just remove that but please leave the comment there.
There was a problem hiding this comment.
Its a wrong fix definetly and I wasn't aware if it was an exercise, as I was also getting build failure in doing make docs :p
As I am getting my senses back I see this is wrong solution I have posted.
There was a problem hiding this comment.
Only thing that bothers me here is without using the comments I can compile it easily. So what headers we need, as error says nothing about header missing.
|
@dbaluta, I think it's a good exercise. It'a a troubleshooting exercise showing what happens when you don't include all headers. We should make it more ambiguous in the exercise statement, but I wouldn't remove it. Please add an issue and close this pull request. |
|
Added the following issue to find a better solution: #132 |
…before string constant'
Signed-off-by: Mrigendra Chaubey [email protected]