Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect label in linux paging figure #407

Closed
wants to merge 2 commits into from
Closed

Fix incorrect label in linux paging figure #407

wants to merge 2 commits into from

Conversation

RoundRaccoon
Copy link

In the address space lecture, at the linux paging figure, there is a typo where the second "PAGE GLOBAL DIRECTORY" should be "PAGE TABLE".

@dbaluta
Copy link
Member

dbaluta commented May 13, 2024

You shouldn't submit the merge commit.

image

... only the first commit should be submitted.

Also, please add some prefix to the commit subject: e.g: Documentation: teaching: address-space: Fix ...

@lkt-bot
Copy link
Collaborator

lkt-bot commented May 13, 2024

@RoundRaccoon RoundRaccoon changed the title Fix incorrect label Documentation: teaching: address-space: Fix incorrect label in linux paging figure May 13, 2024
@RoundRaccoon
Copy link
Author

Thank you for noticing! I closed this PR and made a new one where I removed the merge commit:

@RoundRaccoon RoundRaccoon changed the title Documentation: teaching: address-space: Fix incorrect label in linux paging figure Fix incorrect label in linux paging figure May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants