tests: linters: log a bit more info #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linters might show different results depending on the version. Then, it looks interesting to print these versions to help people reproducing issues on their side. If there is an issue to print the version, exit with an error: this will also help to identify if the linter is missing or if there is something wrong with it. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
To be clearer and to make sure the script is working properly. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
It is clearer, and helpful when multiple files have the same base name. Even more when we only have the SHA to print. To get that, we can simply use an associative array variable. While at it, move some code out of the sub-shells, the same way before and after the patch, to only use these sub-shells when changing directories. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the logs to make sure everything was working as expected, I thought it would be useful to add a bit more info in the logs: