lib/ynl: make ynl_socket a move-only type #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying ynl_socket will result in ynl_sock_destroy() being called twice on the same ynl_sock *. Like other c++ "RAII" types that manage a resource, copying should either be deep or disallowed, and moving should be supported. This commit opts for disallowing copy construction and assignment. Signed-off-by: Daniel Zahka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying ynl_socket will result in ynl_sock_destroy() being called twice on the same ynl_sock *. Like other c++ "RAII" types that manage a resource, copying should either be deep or disallowed, and moving should be supported. This commit opts for disallowing copy construction and assignment.