fix: check mode should not give an error #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause: The blivet module was not looking for the check_mode flag before reporting an error when the supporting modules could not be loaded. Consequence: The storage role would give an error in check mode in the "Get required packages" task. Fix: See if the role is running in check mode, and do not report an error if the underlying modules cannot be loaded. This is expected. Result: The storage role does not print an error when running in check mode. Signed-off-by: Rich Megginson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 16.54% 10.76% -5.79%
==========================================
Files 2 8 +6
Lines 284 1942 +1658
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1733 +1496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause: The blivet module was not looking for the check_mode flag before
reporting an error when the supporting modules could not be loaded.
Consequence: The storage role would give an error in check mode in the
"Get required packages" task.
Fix: See if the role is running in check mode, and do not report an
error if the underlying modules cannot be loaded. This is expected.
Result: The storage role does not print an error when running in
check mode.
Signed-off-by: Rich Megginson [email protected]