fix: Add libblockdev s390 and FS plugins to blivet dependencies list #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libblockdev-s390 is available only on s390x architecture so we can't add it as dependency everywhere.
Latest blivet on Fedora and RHEL/CentOS 10 uses libblockdev FS plugin for filesystem operations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 16.54% 10.73% -5.81%
==========================================
Files 2 8 +6
Lines 284 1946 +1662
Branches 79 0 -79
==========================================
+ Hits 47 209 +162
- Misses 237 1737 +1500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Tests pass el9 and el10 on s390x - no regressions seen either |
richm
approved these changes
Aug 2, 2024
richm
added a commit
to richm/linux-system-roles-storage
that referenced
this pull request
Aug 16, 2024
Due to linux-system-roles#467 architecture is now a required Ansible fact Signed-off-by: Rich Megginson <[email protected]>
richm
added a commit
that referenced
this pull request
Aug 16, 2024
Due to #467 architecture is now a required Ansible fact Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The s390 plugin is needed everywhere but on s390 only (it is not available on other architectures). The filesystem plugin is needed only on Fedora and CentOS/RHEL 10.