-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Appstream metadata XML with hardware mapping. #28
base: master
Are you sure you want to change the base?
Added Appstream metadata XML with hardware mapping. #28
Conversation
This allow linux distributions collecting such information to propose this package when the relevant hardware is present in a computer, as implemented with the isenkram system. This is also reported as <URL: https://bugs.debian.org/840560 >.
@@ -0,0 +1,31 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<component> | |||
<id>com.github.evgeni.hdapsd</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be com.github.linux-thinkpad.hdapsd
, right?
</description> | ||
<url type="homepage">https://github.com/evgeni/hdapsd</url> | ||
<provides> | ||
<modalias>dmi:*:pn*:pvrThinkPad*:rvn*</modalias> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this make hdapsd
automatically installed on all ThinkPads?
I don't think that Thinkpads shipped with rotating disks for the last 10 years, and the ones from the last 5 years probably don't even support rotating disks at all, so it seems wrong to suggest this tool for these?
[Evgeni Golov]
This should be `com.github.linux-thinkpad.hdapsd`, right?
It can be anything, as long as it is unique, in reverse DNS notation and
matches the file name of the XML file. I do not know what it should be,
I just picked a random ID based on the Homepage URL used in the Debian
package when I initialy wrote the XML file. Your proposal is just as
good as mine. Note, '-' should be avoided, and I tend to replace it
with '_' if it is part of a DNS or project name fragment.
Will this make `hdapsd` automatically installed on *all* ThinkPads? I
don't think that Thinkpads shipped with rotating disks for the last 10
years, and the ones from the last 5 years probably don't even support
rotating disks at all, so it seems wrong to suggest this tool for
these?
There is currently nothing automatically installing it, but yes, the
modalias glob will match all Thinkpads. Perhaps you have a more fitting
match expression? 'cat $(find /sys -name modalias)|sort -u' can provide
some ideas.
…--
Happy hacking
Petter Reinholdtsen
|
This allow linux distributions collecting such information to propose this package when the relevant hardware is present in a computer, as implemented with the isenkram system.
This is also reported as <URL: https://bugs.debian.org/840560 >.