-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor implement step runner #48
Conversation
a7f762a
to
53e21d1
Compare
StepRunner logic is covered by TestRunner unit tests. |
9c362f1
to
c5098b3
Compare
Cool, tests found existing race-condition, in case of an error, we may not "switch" to result processing branch in waitStepRunners method time="2021-11-25T23:30:03Z" level=debug msg="monitor: active" file="test_runner.go:611"
FAIL Another test fails because it lasted 7 seconds instead of 5... The test checks exec plugin that launches actual ssh stuff. Will extend timeout. |
you are welcome :) |
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 66.25% 66.47% +0.22%
==========================================
Files 156 157 +1
Lines 9346 9457 +111
==========================================
+ Hits 6192 6287 +95
- Misses 2488 2501 +13
- Partials 666 669 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
40d3afd
to
e236ec9
Compare
2b60d09
to
0aa919e
Compare
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
…ing loops exited Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
…eady Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
…d race condition. Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
StepRunner.Run() consumes output callbacks Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
0aa919e
to
462f278
Compare
Signed-off-by: Ilya <[email protected]>
Clear StepRunner.WaitResult() signature Signed-off-by: Ilya <[email protected]>
Make StepRunner.Run() use channels for communicating results Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
Signed-off-by: Ilya <[email protected]>
6ee432d
to
62d049c
Compare
Move all logic that manages running of a TestStep in a separate TestRunner.
This refactoring is needed to make retries of steps look better.
Special thanks to @rojer for a large number of unit tests :)