-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hashes.txt contains no hash for the 12M rom #1534
Comments
Will need to test on clean build. Last time that was fixed was under ba9235a prior of zip file creation for all boards but excluded ones. |
Clean build log console output (rebasing #1522 before force push, so new unique commit)
output in hashes.txt:
@gaspar-ilom is this because you have rebuilt a same commit maybe? This is Makefile driven so if 12mb rom exists, its not recreated and therefore hash is not outputted on screen nor on hashes.txt file. You can wipe content of build dir and try again a build and the hashes should output on both console and hashes.txt file. @gaspar-ilom Let me know how that goes and close issue if not an issue |
Actually, I did not even build the rom myself but just used the build from circleci. I probably should have mentioned that. To me the hashes.txt in the circleci build still looks the same after the rebase: https://app.circleci.com/pipelines/github/tlaurion/heads/2120/workflows/e15ee75d-f62a-4c1b-9e02-aad2ef20efbd/jobs/36345 |
I see.
I'll check Makefile (global and board config) to understand why output of full rom is under build log but not under hashes.txt/sizes.txt This is a bug and is reproducible. This bug reappeared between commit above which splits the ROMs for dual spi boards for external flashing and now. |
but the the hash for the bottom rom shows up twice. The same happens also for other boards like the t440p. I did not analyze this, just something I found worth mentioning.
Originally posted by @gaspar-ilom in #1522 (comment)
The text was updated successfully, but these errors were encountered: