BUGFIX: targets/split_8mb4mb.mk Makefile: Make sure top/bottom/rom hash+size are always outputted in console+hashes.txt+sizes.txt #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
tlaurion
force-pushed
the
fix_target-split_8mb4mb_mk
branch
from
1f25857 to
92b99dc
Compare
|
@JonathonHall-Purism : better approach with your Make fu? |
tlaurion
force-pushed
the
fix_target-split_8mb4mb_mk
branch
from
92b99dc to
9e3f0fe
Compare
…sh+size are always outputted in console+hashes.txt+sizes.txt Signed-off-by: Thierry Laurion <[email protected]>
tlaurion
force-pushed
the
fix_target-split_8mb4mb_mk
branch
from
9e3f0fe to
a0c3d8e
Compare
|
@JonathonHall-Purism punched an exclusion in global Makefile in case not spllitted 12mb rom image. Best I could imagine! Works locally (tested nv41/t430 to address #1829 (comment) which revived need to fix #1534 for pending feature freeze/bugfixes) |
| $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-top.rom: $(board_build)/$(CB_OUTPUT_FILE) | ||
| $(call do,DD 4MB,$@,dd of=$@ if=$< bs=65536 count=64 skip=128 status=none) | ||
| @sha256sum $@ | tee -a "$(HASHES)" | ||
| bottom: $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION)-bottom.rom |
There was a problem hiding this comment.
If you want, you could make a variable that holds $(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION) because that's so long and repeated so many times, e.g. BUILD_ROM_PREFIX=$(board_build)/heads-$(BOARD)-$(HEADS_GIT_VERSION). But not required at all, I'd be happy merging as-is.
JonathonHall-Purism
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1534