Skip to content

Commit

Permalink
fix:
Browse files Browse the repository at this point in the history
Log:

Bug:
fix: optimize search edit widget signal connection

- Change textChanged signal to textEdited to avoid unnecessary signal emissions
- Remove redundant DTK macro check for DSizeMode header
- Fix signal-slot connection to prevent potential text processing issues

Log: This commit fixes the search widget's behavior by using textEdited instead
of textChanged signal, which only triggers when user actually types or
modifies the text, avoiding unnecessary signal emissions from programmatic
text changes.
  • Loading branch information
Johnson-zs committed Nov 24, 2024
1 parent 397842e commit ff748fe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
#include <DSpinner>
#include <DDialog>
#include <DGuiApplicationHelper>
#ifdef DTKWIDGET_CLASS_DSizeMode
#include <DSizeMode>
#endif

#include <QHBoxLayout>
#include <QResizeEvent>
Expand Down Expand Up @@ -154,7 +152,7 @@ void SearchEditWidget::onReturnPressed()
startSpinner();
}

void SearchEditWidget::onTextChanged(const QString &text)
void SearchEditWidget::onTextEdited(const QString &text)
{
lastEditedString = text;
if (text.isEmpty()) {
Expand Down Expand Up @@ -367,7 +365,7 @@ void SearchEditWidget::initUI()
void SearchEditWidget::initConnect()
{
connect(searchButton, &DIconButton::clicked, this, &SearchEditWidget::expandSearchEdit);
connect(searchEdit, &DSearchEdit::textChanged, this, &SearchEditWidget::onTextChanged, Qt::QueuedConnection);
connect(searchEdit, &DSearchEdit::textEdited, this, &SearchEditWidget::onTextEdited, Qt::QueuedConnection);
connect(searchEdit, &DSearchEdit::returnPressed, this, &SearchEditWidget::onReturnPressed);
connect(searchEdit, &DSearchEdit::searchAborted, this, [this]() {
stopSpinner();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public Q_SLOTS:
void onPauseButtonClicked();
void onAdvancedButtonClicked();
void onReturnPressed();
void onTextChanged(const QString &text);
void onTextEdited(const QString &text);
void onClearSearchHistory(quint64 winId);
void onDConfigValueChanged(const QString &config, const QString &key);

Expand Down

0 comments on commit ff748fe

Please sign in to comment.