Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [sidebar] Sidebar Item editor not vertical centering #2438

Open
wants to merge 1 commit into
base: release/eagle
Choose a base branch
from
Open

fix: [sidebar] Sidebar Item editor not vertical centering #2438

wants to merge 1 commit into from
+2 −1

Conversation

GongHeng2017
Copy link
Contributor

change UI

Log: fix issue
Bug: https://pms.uniontech.com/bug-view-278245.html

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码修改提高了编辑器在垂直方向上的对齐方式，使得编辑器在垂直方向上居中对齐。

是否建议立即修改:

  • 否，这次提交的修改看起来是合理的，没有发现需要立即修改的问题。但是，建议进行以下检查和改进：
    • 确认修改后的对齐方式是否符合设计要求。
    • 检查是否有其他地方需要更新以保持一致性。
    • 如果有更多的上下文代码，可以进一步检查是否有其他潜在的问题。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017
Copy link
Contributor Author

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 30, 2024

This pr cannot be merged! (status: behind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johnson-zs Johnson-zs Johnson-zs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GongHeng2017 @deepin-ci-robot @Johnson-zs