Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: desktop links are classify into others. #2449

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Dec 2, 2024

as above.

Log: as above.

Bug: bbs.deepin.org.cn/post/281955

Johnson-zs
Johnson-zs previously approved these changes Dec 2, 2024
as above.

Log: as above.

Bug: bbs.deepin.org.cn/post/281955
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 循环深度硬编码为3,应该定义为常量或配置项,以便于调整
  • 缺少对itemInfonullptr的检查,可能导致空指针异常
  • continue语句在循环中可能导致逻辑错误,应该重新考虑循环逻辑

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 2, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 46e2bd2 into linuxdeepin:master Dec 2, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants