[email protected] :Refactor Bing Wallpaper Applet Code for Enhanced Maintainability

[tesfayegirma-116]

Bing Wallpaper Cinnamon Applet

Overview

This repository contains the code for the Bing Wallpaper Cinnamon Applet. The applet sets the Bing daily wallpaper as your desktop background. Recent updates include:

• Code Refactoring: Improved maintainability and organization.
• Module Import Fixes: Resolved issues with module paths and imports.

Changes

Refactor and Fixes

• Code Refactoring:

  • Separation of Concerns: Code split into distinct modules for better organization.
  • Enhanced Documentation: Added comprehensive comments and documentation for clarity.

• Code Organization:

  • Best Practices: Followed best practices for file structure and module management.

File Structure

Ensure your file structure matches the following:

~/.local/share/cinnamon/applets/[email protected]/
├── applet.js
├── httpClient.js
├── fileManager.js
├── settingsManager.js
└── utils.js


@Starcross 

[fredcw]

Ping @Starcross

[Starcross]

Thanks for your PR. I left a couple of comments, but I think basic functionality is also broken at the moment. Looking at the logs alone it seems like handling the metadata has an issue. I'm often seeing this error, so it's probably a good starting point:

info t=2024-07-20T18:05:11Z [[email protected]]: Unable to get local metadata: TypeError: this.imageData is undefined

[Starcross]

Not sure I understand this comment. The intention here is to replace the resolution with _UHD, which will get the highest resolution image available

[Starcross]

This image is almost certainly owned and copyright by Microsoft, and I would not expect them to permit this kind of use without permission.

I would argue this would also lend a bit of a microsoft/windows flavour to the applet, which I'm not sure our audience would enjoy

[tesfayegirma-116]

Thanks for your PR. I left a couple of comments, but I think basic functionality is also broken at the moment. Looking at the logs alone it seems like handling the metadata has an issue. I'm often seeing this error, so it's probably a good starting point:

info t=2024-07-20T18:05:11Z [[email protected]]: Unable to get local metadata: TypeError: this.imageData is undefined

@Starcross No problem! Thanks for checking it out. It’s my first time asking for contributions, so I’m as excited as a puppy with two tails! 🐶✨