Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radio@driglu4it]: fix icons very large on new cinnamon #6782

Merged

Conversation

jonath92
Copy link
Contributor

Without the fix, it looks like that on Linux Mint 22.1

image

@rcalixte
Copy link
Member

Without the fix, it looks like that on Linux Mint 22.1

Have you tested this on older versions of Cinnamon?

@jonath92
Copy link
Contributor Author

No I haven't but I am optimistic that it works because in the past the "icon-size:16px" has been included in the mint-y cinnamon.css (see: linuxmint/mint-themes@78965ce#diff-91f9c5ba3758104f896731e0373b935687baa6a5ba0ff731513cc68cd28b42eaL307) and for mint-x it seems to be still included. There is a small change it get broken 3rd party themes but that than needs to be fixed by the theme author (e.g. by using "important"). However I tested with Adapta-Nokto and there it still works.

@rcalixte
Copy link
Member

Hmm. It would be nice to know that this doesn't break anyone with Mint who hasn't upgraded or anyone not running Mint but still using Cinnamon. Would it make sense to move this to a versioned subdirectory?

@jonath92
Copy link
Contributor Author

yes, makes sense. I have added a new version

@rcalixte rcalixte merged commit 7c71b85 into linuxmint:master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants