only kill a task if its pid is set #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not looked at the code, but, judging by the problems that you say you are fixing, you are doing great and necessary work here. Well done, and thank you. |
|
I implemented the estimation as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #366
If a user cancels a task, when it was not started, timeshift may try to kill many processes. I also made sure to initilize all values in
AsyncTaskto some sensible defaults.This results in the estimation task not beeing cancelable. If a user presses cancel, while the estimation is still running, the window will close, but the estimation will continue in the background. Even if timeshift was closed. Solving this is a bit more involved, as it requires to run the rsync process async and storing its pid somewhere. It might be usefull to implement it as
AsyncTask.