Prepare porting to meson buildsytem #317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hsbasu
commented
Oct 21, 2024
hsbasu
commented
- Setup meson to install python sources during meson builds
- Install executable binary using meson
- Update debian builds to use meson
- Update testing script
hsbasu
force-pushed
the
meson-buildsytem
branch
from
ba07efe to
37ddb06
Compare
|
@clefebvre @mtwebster A gentle reminder. |
clefebvre
changed the title
clefebvre
changed the title
|
Hi, I'm not sure why you've added gtk4 dependencies - this is still a gtk3 app. The postinst/postrm work is unnecessary - see https://github.com/linuxmint/warpinator/tree/master/install-scripts for an example of how to handle this stuff. |
|
Thanks @mtwebster . I'll modify them. |
- Setup meson to install python sources during meson builds - Install executable binary using meson - Update debian builds to use meson - Update testing script
mtwebster
reviewed
May 26, 2025
Comment on lines
+30
to
+45
| # Install schema file | ||
| schema_file = i18n.merge_file( | ||
| input: 'org.x.webapp-manager.gschema.xml.in', | ||
| output: 'org.x.webapp-manager.gschema.xml', | ||
| type: 'xml', | ||
| po_dir: '../po', | ||
| install: true, | ||
| install_dir: schema_dir | ||
| ) | ||
|
|
||
| compile_schemas = find_program('glib-compile-schemas', required: false) | ||
| if compile_schemas.found() | ||
| test('Validate schema file', | ||
| compile_schemas, | ||
| args: ['--strict', '--dry-run', meson.current_source_dir()]) | ||
| endif |
There was a problem hiding this comment.
Schema files don't need localized or checked, just install_data()
mtwebster
reviewed
May 26, 2025
| desktop-file-utils, | ||
| dh-python, | ||
| libglib2.0-bin, | ||
| libgtk-4-bin, |
mtwebster
reviewed
May 26, 2025
|
|
||
| #DEBHELPER# | ||
|
|
||
| exit 0 |
There was a problem hiding this comment.
remove postinst file, it gets auto-generated.
mtwebster
reviewed
May 26, 2025
|
|
||
| #DEBHELPER# | ||
|
|
||
| exit 0 |
There was a problem hiding this comment.
postrm is also autogenerated.
mtwebster
reviewed
May 26, 2025
Comment on lines
+13
to
+23
|
|
||
| # # Inject version number in the code | ||
| # override_dh_installdeb: | ||
| # dh_installdeb | ||
| # for pkg in $$(dh_listpackages -i); do \ | ||
| # find debian/$$pkg -type f -exec sed -i -e s/__DEB_VERSION__/$(DEB_VERSION)/g {} +; \ | ||
| # done | ||
|
|
||
| override_dh_auto_build: | ||
| dh_auto_build -O--buildsystem=meson | ||
| make -j8 |
mtwebster
reviewed
May 26, 2025
Comment on lines
+22
to
+30
| import re | ||
| import sys | ||
|
|
||
| sys.path.insert(1, '@pkgdatadir@') | ||
|
|
||
| from WebappManager.main import main | ||
| if __name__ == '__main__': | ||
| sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0]) | ||
| sys.exit(main()) |
There was a problem hiding this comment.
Keep this as just a simple launcher... like:
#!/bin/sh
@install_libdir@/webapp-manager.py &
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.