-
Notifications
You must be signed in to change notification settings - Fork 103
Prepare porting to meson buildsytem #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hsbasu
commented
Oct 21, 2024
- Setup meson to install python sources during meson builds
- Install executable binary using meson
- Update debian builds to use meson
- Update testing script
ba07efe
to
37ddb06
Compare
@clefebvre @mtwebster A gentle reminder. |
Hi, I'm not sure why you've added gtk4 dependencies - this is still a gtk3 app. The postinst/postrm work is unnecessary - see https://github.com/linuxmint/warpinator/tree/master/install-scripts for an example of how to handle this stuff. |
Thanks @mtwebster . I'll modify them. |
- Setup meson to install python sources during meson builds - Install executable binary using meson - Update debian builds to use meson - Update testing script
# Install schema file | ||
schema_file = i18n.merge_file( | ||
input: 'org.x.webapp-manager.gschema.xml.in', | ||
output: 'org.x.webapp-manager.gschema.xml', | ||
type: 'xml', | ||
po_dir: '../po', | ||
install: true, | ||
install_dir: schema_dir | ||
) | ||
|
||
compile_schemas = find_program('glib-compile-schemas', required: false) | ||
if compile_schemas.found() | ||
test('Validate schema file', | ||
compile_schemas, | ||
args: ['--strict', '--dry-run', meson.current_source_dir()]) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema files don't need localized or checked, just install_data()
desktop-file-utils, | ||
dh-python, | ||
libglib2.0-bin, | ||
libgtk-4-bin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove gtk4 dep
|
||
#DEBHELPER# | ||
|
||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove postinst file, it gets auto-generated.
|
||
#DEBHELPER# | ||
|
||
exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postrm is also autogenerated.
|
||
# # Inject version number in the code | ||
# override_dh_installdeb: | ||
# dh_installdeb | ||
# for pkg in $$(dh_listpackages -i); do \ | ||
# find debian/$$pkg -type f -exec sed -i -e s/__DEB_VERSION__/$(DEB_VERSION)/g {} +; \ | ||
# done | ||
|
||
override_dh_auto_build: | ||
dh_auto_build -O--buildsystem=meson | ||
make -j8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need any of this.
import re | ||
import sys | ||
|
||
sys.path.insert(1, '@pkgdatadir@') | ||
|
||
from WebappManager.main import main | ||
if __name__ == '__main__': | ||
sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0]) | ||
sys.exit(main()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this as just a simple launcher... like:
#!/bin/sh
@install_libdir@/webapp-manager.py &