Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zwavejs2Mqtt #537

Merged
merged 8 commits into from
Jan 27, 2024
Merged

Add Zwavejs2Mqtt #537

merged 8 commits into from
Jan 27, 2024

Conversation

Dallas-J
Copy link
Contributor

No description provided.

@dgibbs64
Copy link
Collaborator

missing logo

@Dallas-J
Copy link
Contributor Author

Updated with logo, let me know if you think it displays poorly and I can edit it.

@mvdkleijn
Copy link
Collaborator

Hey @Dallas-J I'm a new contributor working through old PRs. Yours is almost good to go. Could you update the PR by renaming the directory to "Zwavejs2Mqtt" please?

Copy link
Collaborator

@mvdkleijn mvdkleijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some stuff myself, you just need to update the directory name.

@Dallas-J
Copy link
Contributor Author

Done, thanks for working through the backlog here!

@mvdkleijn
Copy link
Collaborator

LGTM. Merging. Some linter errors but I need to update that dufus check anyways.

@mvdkleijn mvdkleijn merged commit b537609 into linuxserver:master Jan 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants