AVMFritzBox: add override url config to allow reverse proxied linking urls #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bl4d3s
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the default override url config option for the AVM Fritzbox app.
This is needed if the user is running a reverse proxy like NGINX and would like to enter the proxied URL like https://fritzbox.example.com as linking url.
As the URL is used with a custom port for the API queries, these fail when doing so.
To fix this, I enabled the override option for the url.
Now I am able to specify the linking url as https://fritzbox.example.com and the API (override) url as http://10.0.0.1 (or any other IP/domain)