add passbook #692
Closed
add passbook #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdkleijn
requested changes
Feb 18, 2024
|
Also, it doesn't have an icon. Please see the wiki for details on the icon. An icon is required. |
|
Lastly, the passbolt files don't pass the codesniffer tests. This implies to me that you copied old code from somewhere instead of using the developer template. New PRs using the dev templates should pass the codesniffer checks. Specifically see the code sniffer results in the failed tests. |
|
Added the foundation app in PR #702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.