Fix proxmox with offline node #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l prevent throwing an exception if one node is offline.
|
Please correct the issues mentioned in the codesniffer check. Other than that LGTM. |
|
Hi @mvdkleijn, I've fixed the errors. I also added the ident config for PHP files to the .editorconfig, so IDE's supporting it will automatically use the correct style. |
|
Thanks! (sorry for the delayed response, holidays here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this fixes that no information shown for proxmox if one node of the cluster is turned of for some reason.
Feel free to check and merge.