Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable Items with authentification headers #1304

Open
wants to merge 13 commits into
base: 2.x
Choose a base branch
from

Conversation

tkolzer
Copy link

@tkolzer tkolzer commented Feb 28, 2024

Use case:

  • the Heimdall server is located behind a login page provides by a SSO service like authelia or Keycloak
  • You want to define common services only once and share them between users enabled by the roles they're assigned to

New feature when enabled:

  • The Heimdall setings (order of items, application list, tag list, settings) are only visible for users with role admin.
  • For every application and tag the new field Authentification role is added. This filed contains the role to witch the application or tag is displayed.
  • Applications and tags are only displayed when the logged in user is member of the configured role.

Configuration:

  • The feature can be enabled/disabled in the env file with AUTH_ROLES_ENABLE.
  • It is possible to configure the header containg the roles by AUTH_ROLES_HEADER and AUTH_ROLES_HTTP_HEADER.
  • The role to enable the Heimdall settings can be set wit AUTH_ROLES_ADMIN.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Mar 29, 2024

@KodeStar can I get some feedback to this merge request.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Apr 30, 2024

@KodeStar can I get some feedback to this merge request.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Jun 2, 2024

@KodeStar can I get some feedback to this merge request.

Copy link

@albinmedoc albinmedoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have found some misspelling, please take a look.

resources/lang/en/app.php Outdated Show resolved Hide resolved
resources/lang/de/app.php Outdated Show resolved Hide resolved
resources/views/userselect.blade.php Outdated Show resolved Hide resolved
resources/views/auth/login.blade.php Outdated Show resolved Hide resolved
@albinmedoc
Copy link

I can make a new review when the problems are resolved.

@tkolzer
Copy link
Author

tkolzer commented Jun 15, 2024

@albinmedoc I corrected the misspellings

Copy link

@albinmedoc albinmedoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some more issues that need to be resolved

config/app.php Outdated Show resolved Hide resolved
resources/lang/en/app.php Outdated Show resolved Hide resolved
@albinmedoc
Copy link

Sorry for not adding all suggestions at one time.
This is the last one. Then I'm happy.

Copy link

@albinmedoc albinmedoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albinmedoc
Copy link

Looks likes branch has conflicts that must be resolved, please rebase and fix conflicts.

@tkolzer
Copy link
Author

tkolzer commented Jun 20, 2024

@albinmedoc the merge conflicts should now be solved

Copy link

@albinmedoc albinmedoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Jul 29, 2024

@KodeStar can I get some feedback to this merge request.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Aug 29, 2024

@KodeStar can I get some feedback to this merge request.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Sep 28, 2024

@KodeStar can I get some feedback to this merge request.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@tkolzer
Copy link
Author

tkolzer commented Oct 30, 2024

@KodeStar can I get some feedback to this merge request.

@KodeStar
Copy link
Member

KodeStar commented Nov 4, 2024

Sorry @tkolzer, looks good to me, add some details in the README on what it's for and how to use it and I'll merge it.

@KodeStar
Copy link
Member

KodeStar commented Nov 4, 2024

It looks like the roles only work with folder type tags, is this expected behaviour?

@KodeStar
Copy link
Member

KodeStar commented Nov 4, 2024

"controles" should probably be "controls"

@albinmedoc
Copy link

@tkolzer Do you need help resolving the issues?

@tkolzer
Copy link
Author

tkolzer commented Nov 24, 2024

@albinmedoc at the moment I'm a bit short of time due to my ongoing Master's programme. I hope I have some free time in December.

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants