Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about newlines in secrets (arch) #22

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Warn about newlines in secrets (arch) #22

merged 3 commits into from
Nov 11, 2023

Conversation

thespad
Copy link
Member

@thespad thespad commented Nov 10, 2023

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

See linuxserver/docker-baseimage-alpine#198

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team November 10, 2023 14:47
@thespad thespad self-assigned this Nov 10, 2023
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-10-pkg-6c0e595b-dev-eacc55142f4574a63c0902e1d29382a55bc483f8-pr-22/index.html
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-10-pkg-6c0e595b-dev-eacc55142f4574a63c0902e1d29382a55bc483f8-pr-22/shellcheck-result.xml

Tag Passed
amd64-2023-11-10-pkg-6c0e595b-dev-eacc55142f4574a63c0902e1d29382a55bc483f8-pr-22 ✅
arm64v8-2023-11-10-pkg-6c0e595b-dev-eacc55142f4574a63c0902e1d29382a55bc483f8-pr-22 ✅

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-11-pkg-408dd667-dev-8b8ba68146c2e0676d338c826f132e44728fb09f-pr-22/index.html
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-11-pkg-408dd667-dev-8b8ba68146c2e0676d338c826f132e44728fb09f-pr-22/shellcheck-result.xml

Tag Passed
amd64-2023-11-11-pkg-408dd667-dev-8b8ba68146c2e0676d338c826f132e44728fb09f-pr-22 ✅
arm64v8-2023-11-11-pkg-408dd667-dev-8b8ba68146c2e0676d338c826f132e44728fb09f-pr-22 ✅

@thespad thespad changed the title Default to sanitizing newlines in secrets Warn about newlines in secrets (arch) Nov 11, 2023
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-11-pkg-408dd667-dev-21d00425e36d149679cadf9acfa3dd6cadc849d5-pr-22/index.html
https://ci-tests.linuxserver.io/lspipepr/arch/2023-11-11-pkg-408dd667-dev-21d00425e36d149679cadf9acfa3dd6cadc849d5-pr-22/shellcheck-result.xml

Tag Passed
amd64-2023-11-11-pkg-408dd667-dev-21d00425e36d149679cadf9acfa3dd6cadc849d5-pr-22 ✅
arm64v8-2023-11-11-pkg-408dd667-dev-21d00425e36d149679cadf9acfa3dd6cadc849d5-pr-22 ✅

@thespad thespad merged commit 4901890 into master Nov 11, 2023
4 checks passed
@thespad thespad deleted the master-secrets branch November 11, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees

@thespad thespad

Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thespad @LinuxServer-CI @nemchik