-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config files no longer used, now stored in sqlite db, fixed docs spec… #63
Conversation
…ifying ES authentication, default to off
I am a bot, here are the test results for this PR:
|
This would be a good opportunity to rebase to 3.20 as well |
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
Humble request that the admins merge this! This took a long time to set up given that the current Docker Compose file in the README does not work as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebasing to 3.20 (unless there's some dep, etc. stopping that) - and as part of that the default nginx conf needs updating to remove the http2
from the listeners as that's now deprecated.
You haven't updated the arm Dockerfile, is that intentional?
I'd also recommend rerunning the Jenkins builder locally as there's been a big monthly merged since this PR was opened, though it shouldn't break anything if you don't.
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
…ifying ES authentication, default to off
Description:
Benefits of this PR and context:
How Has This Been Tested?
Source / References: