Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config files no longer used, now stored in sqlite db, fixed docs spec… #63

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

alex-phillips
Copy link
Member

…ifying ES authentication, default to off

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-41328492-dev-0fc8259931197ad31c6e7f1dc670500538ac47d6-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-41328492-dev-0fc8259931197ad31c6e7f1dc670500538ac47d6-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-41328492-dev-0fc8259931197ad31c6e7f1dc670500538ac47d6-pr-63
arm64v8-v2.2.2-pkg-41328492-dev-0fc8259931197ad31c6e7f1dc670500538ac47d6-pr-63

@thespad
Copy link
Member

thespad commented Jun 22, 2024

This would be a good opportunity to rebase to 3.20 as well

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-41328492-dev-4054776b6bfb5f3c40b7eadec184eafe52020239-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-41328492-dev-4054776b6bfb5f3c40b7eadec184eafe52020239-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-41328492-dev-4054776b6bfb5f3c40b7eadec184eafe52020239-pr-63
arm64v8-v2.2.2-pkg-41328492-dev-4054776b6bfb5f3c40b7eadec184eafe52020239-pr-63

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-b90383ae-dev-648b5c4d09d1e7bc75dd069c601639aedd426d4a-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-b90383ae-dev-648b5c4d09d1e7bc75dd069c601639aedd426d4a-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-b90383ae-dev-648b5c4d09d1e7bc75dd069c601639aedd426d4a-pr-63
arm64v8-v2.2.2-pkg-b90383ae-dev-648b5c4d09d1e7bc75dd069c601639aedd426d4a-pr-63

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-4f6194d0-dev-5306a1dc9b46a50bec21106e7ee7385a07c23e77-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-4f6194d0-dev-5306a1dc9b46a50bec21106e7ee7385a07c23e77-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-4f6194d0-dev-5306a1dc9b46a50bec21106e7ee7385a07c23e77-pr-63
arm64v8-v2.2.2-pkg-4f6194d0-dev-5306a1dc9b46a50bec21106e7ee7385a07c23e77-pr-63

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-4b12bd33-dev-dcefbcc9db5f2a5382a6413f76ded349e3ad073c-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-4b12bd33-dev-dcefbcc9db5f2a5382a6413f76ded349e3ad073c-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.3.0-pkg-4b12bd33-dev-dcefbcc9db5f2a5382a6413f76ded349e3ad073c-pr-63
arm64v8-v2.3.0-pkg-4b12bd33-dev-dcefbcc9db5f2a5382a6413f76ded349e3ad073c-pr-63

@blisst
Copy link

blisst commented Aug 24, 2024

Humble request that the admins merge this! This took a long time to set up given that the current Docker Compose file in the README does not work as is.

Copy link
Member

@thespad thespad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing to 3.20 (unless there's some dep, etc. stopping that) - and as part of that the default nginx conf needs updating to remove the http2 from the listeners as that's now deprecated.

You haven't updated the arm Dockerfile, is that intentional?

I'd also recommend rerunning the Jenkins builder locally as there's been a big monthly merged since this PR was opened, though it shouldn't break anything if you don't.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-8081c7b79240efb7f8974cde7e4b3e9805d8fcc9-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-8081c7b79240efb7f8974cde7e4b3e9805d8fcc9-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.3.0-pkg-e7bb59a5-dev-8081c7b79240efb7f8974cde7e4b3e9805d8fcc9-pr-63
arm64v8-v2.3.0-pkg-e7bb59a5-dev-8081c7b79240efb7f8974cde7e4b3e9805d8fcc9-pr-63

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-e860f59854aecd8fe14c5f7712337964b7cd2ee7-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-e860f59854aecd8fe14c5f7712337964b7cd2ee7-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.3.0-pkg-e7bb59a5-dev-e860f59854aecd8fe14c5f7712337964b7cd2ee7-pr-63
arm64v8-v2.3.0-pkg-e7bb59a5-dev-e860f59854aecd8fe14c5f7712337964b7cd2ee7-pr-63

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-4fc0f0e891ef89174bd8c4ccabe003b494bcccf1-pr-63/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.0-pkg-e7bb59a5-dev-4fc0f0e891ef89174bd8c4ccabe003b494bcccf1-pr-63/shellcheck-result.xml

Tag Passed
amd64-v2.3.0-pkg-e7bb59a5-dev-4fc0f0e891ef89174bd8c4ccabe003b494bcccf1-pr-63
arm64v8-v2.3.0-pkg-e7bb59a5-dev-4fc0f0e891ef89174bd8c4ccabe003b494bcccf1-pr-63

@alex-phillips alex-phillips merged commit 413c918 into master Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants