Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't write config envs to file, check for links not files #118

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Don't write config envs to file, check for links not files #118

merged 3 commits into from
Jan 25, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented Jan 24, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team January 24, 2024 19:07
@thespad thespad self-assigned this Jan 24, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-990d0184-dev-d3177ebab7499b819de28fd7b6cd71bb74bccac3-pr-118/index.html
https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-990d0184-dev-d3177ebab7499b819de28fd7b6cd71bb74bccac3-pr-118/shellcheck-result.xml

Tag Passed
amd64-v3.1-pkg-990d0184-dev-d3177ebab7499b819de28fd7b6cd71bb74bccac3-pr-118 ✅
arm64v8-v3.1-pkg-990d0184-dev-d3177ebab7499b819de28fd7b6cd71bb74bccac3-pr-118 ❌

drizuid
drizuid approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - reported in discord

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-990d0184-dev-c34e7a45a09a88444f7beb05782bdedaad588dc1-pr-118/index.html
https://ci-tests.linuxserver.io/lspipepr/healthchecks/v3.1-pkg-990d0184-dev-c34e7a45a09a88444f7beb05782bdedaad588dc1-pr-118/shellcheck-result.xml

Tag Passed
amd64-v3.1-pkg-990d0184-dev-c34e7a45a09a88444f7beb05782bdedaad588dc1-pr-118 ✅
arm64v8-v3.1-pkg-990d0184-dev-c34e7a45a09a88444f7beb05782bdedaad588dc1-pr-118 ❌

@thespad thespad merged commit 1202677 into master Jan 25, 2024
5 checks passed
@thespad thespad deleted the ephemeral-config branch January 25, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drizuid drizuid drizuid approved these changes

Assignees

@thespad thespad

Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thespad @LinuxServer-CI @drizuid