Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to baseimage-alpine v3.19 #82

Closed
wants to merge 3 commits into from

Conversation

seanD111
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changed baseimage-alpine:3.18 to baseimage-alpine:3.19 in Dockerfiles

Benefits of this PR and context:

Rebasing to alpine 3.19 makes this image more consistent with others (i.e., swag) especially when it comes to packages pulled from the alpine apk community index http://dl-cdn.alpinelinux.org/alpine/v{version}/community/x86_64/APKINDEX.tar.gz

How Has This Been Tested?

I cloned this fork and used it to build a service in a docker-compose file:

services:
  borg-server:
    build: ./docker-openssh-server

With version 3.18, borgmatic-1.7.14-r0.apk would be pulled from the alpine apk community index. With version 3.19, borgmatic-1.8.8-r0.apk would be pulled, which has different syntaxes. After building with 3.19 via compose, borgmatic works consistently with other LinuxServer images that have been rebased to 3.19

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@aptalca aptalca mentioned this pull request Mar 9, 2024
@aptalca
Copy link
Member

aptalca commented Mar 9, 2024

Thanks for the PR, but the rebase for this image requires changes to the Jenkinsfile, which require a team member to open a PR from another repo branch for proper test builds.

We're handling it here: #84

@aptalca aptalca closed this in #84 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants