Display SSH host public keys #86
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
Please use |
|
I am a bot, here are the test results for this PR:
|
|
Thanks, I think I'm happy to approve this, can you just add an entry to the changelog in the readme-vars noting the change. |
|
One question. The PR description states Which is the behavior we want? Display only when they are generated or display them on every start? |
Good spot. IMO the "cost" of displaying the keys is minimal, therefore it's worthwhile displaying them every time the container is started... but I'm happy to edit my code so it does what I said it would do 😄 |
|
Printing on every start probably makes more sense as you are likely to connect a new client at some point after first run so if you want a quick reference for the keys you want it there every time. |
Added an entry dated for tomorrow -- hopefully this is OK? (it's getting late-ish today in my TZ, I didn't want to assume that we'd get the change out today!) |
|
Doesn't need to be spot on, just close enough that if someone has an issue as the result of a change they can see roughtly when it was made. |
|
I am a bot, here are the test results for this PR:
|
Description:
This change displays the SSH host public keys every time the container starts.
Benefits of this PR and context:
Outputting the public keys makes it easier for users to check them when connecting.
How Has This Been Tested?
This is a relatively minor change. I have tested it on my laptop (Ubuntu 22.04 amd64, Docker 24.0.5) and it appears to work. Although I haven't had the opportunity to test the change on an
arm64device I don't see any reason why the change wouldn't work there too.