Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest ffprobe #220

Closed
wants to merge 2 commits into from
Closed

Conversation

zestysoft
Copy link

@zestysoft zestysoft commented Feb 11, 2024

I recently ran into an issue that's being caused by the outdated ffprobe binary that's included in the containers here.

This PR uses a more recent version of the binary which solved my problem. Sharing here in case it's a welcome change.

I also bumped the alpine base and added some missing binaries for the apk add command.

This goes into more detail about the problem I ran into:
https://www.reddit.com/r/radarr/comments/1aog9bh/outdated_ffprobe_binary_failing_to_probe_media/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@thespad
Copy link
Member

thespad commented Feb 11, 2024

Overriding the version of ffprobe that is bundled with Radarr would put us in an unsupported configuration; if you're having issues with the shipped version I'd suggest opening an issue with the Radarr project - or you can customise the container at runtime.

In addition, curl and jq are included in our base images, which is why we don't install them again downstream.

@thespad thespad closed this Feb 11, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/radarr/5.2.6.8376-pkg-9722da3a-dev-90a919ec159e0c8e264e9093def3cc1101cabc6f-pr-220/index.html
https://ci-tests.linuxserver.io/lspipepr/radarr/5.2.6.8376-pkg-9722da3a-dev-90a919ec159e0c8e264e9093def3cc1101cabc6f-pr-220/shellcheck-result.xml

Tag Passed
amd64-5.2.6.8376-pkg-9722da3a-dev-90a919ec159e0c8e264e9093def3cc1101cabc6f-pr-220
arm64v8-5.2.6.8376-pkg-9722da3a-dev-90a919ec159e0c8e264e9093def3cc1101cabc6f-pr-220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants