Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the missing UMASK section. #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

uhop
Copy link

@uhop uhop commented Aug 20, 2024

See #272

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Trivial 3-line section to set UMASK to settings.json as per the current documentation.

Benefits of this PR and context:

It fixes the filed bug, which clearly annoys people (including me).

How Has This Been Tested?

I ran it and saw the change in /config/settings.json.

Source / References:

The existing doc:

## Umask for running applications

The bug: #272

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-6730fbea-dev-20cf81ec2e49fec458e140de6b32f0d733094c47-pr-288/index.html
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-6730fbea-dev-20cf81ec2e49fec458e140de6b32f0d733094c47-pr-288/shellcheck-result.xml

Tag Passed
amd64-4.0.6-r0-pkg-6730fbea-dev-20cf81ec2e49fec458e140de6b32f0d733094c47-pr-288
arm64v8-4.0.6-r0-pkg-6730fbea-dev-20cf81ec2e49fec458e140de6b32f0d733094c47-pr-288

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-f68ac517-dev-356173a6975a42c4e5ed422e07f0af9baf10e8a6-pr-288/index.html
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-f68ac517-dev-356173a6975a42c4e5ed422e07f0af9baf10e8a6-pr-288/shellcheck-result.xml

Tag Passed
amd64-4.0.6-r0-pkg-f68ac517-dev-356173a6975a42c4e5ed422e07f0af9baf10e8a6-pr-288
arm64v8-4.0.6-r0-pkg-f68ac517-dev-356173a6975a42c4e5ed422e07f0af9baf10e8a6-pr-288

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-2cb64b31-dev-f5cd1a2f5fbf0f94c760cef575dbcb3e1410e1fb-pr-288/index.html
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-2cb64b31-dev-f5cd1a2f5fbf0f94c760cef575dbcb3e1410e1fb-pr-288/shellcheck-result.xml

Tag Passed
amd64-4.0.6-r0-pkg-2cb64b31-dev-f5cd1a2f5fbf0f94c760cef575dbcb3e1410e1fb-pr-288
arm64v8-4.0.6-r0-pkg-2cb64b31-dev-f5cd1a2f5fbf0f94c760cef575dbcb3e1410e1fb-pr-288

Copy link
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im tentatively on board with this fix, i forgot about this issue, tbh. Howeever, i have some concerns about weird shit qnap/synology/unraid might do in terms of umask.. i don't think it should cause a problem, but I will ping the rest of the team to give thoughts before merge.

@drizuid drizuid requested a review from a team October 16, 2024 12:48
@drizuid drizuid added the work-in-progress Stale exempt label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale exempt
Projects
Status: PRs Ready For Team Review
Development

Successfully merging this pull request may close these issues.

3 participants