-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the missing UMASK section. #288
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im tentatively on board with this fix, i forgot about this issue, tbh. Howeever, i have some concerns about weird shit qnap/synology/unraid might do in terms of umask.. i don't think it should cause a problem, but I will ping the rest of the team to give thoughts before merge.
See #272
Description:
Trivial 3-line section to set
UMASK
tosettings.json
as per the current documentation.Benefits of this PR and context:
It fixes the filed bug, which clearly annoys people (including me).
How Has This Been Tested?
I ran it and saw the change in
/config/settings.json
.Source / References:
The existing doc:
docker-transmission/README.md
Line 177 in a63cd60
The bug: #272