Skip to content

Commit

Permalink
fix: avoid double negative arguments TDE-1261 (#806)
Browse files Browse the repository at this point in the history
#### Motivation

see linz/argo-tasks#1104

#### Modification

- `no_date_in_survey_path` --> `add_date_in_survey_path`

#### Checklist

- [ ] Tests updated NA
- [x] Docs updated
- [x] Issue linked in Title
  • Loading branch information
paulfouquet authored Oct 10, 2024
1 parent f47a772 commit b851ea5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions templates/argo-tasks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,8 @@ arguments:
value: '{{workflow.parameters.version_argo_tasks}}'
- name: target_bucket_name
value: '{{inputs.parameters.target_bucket_name}}'
- name: no_date_in_survey_path
value: '{{inputs.parameters.no_date_in_survey_path}}'
- name: add_date_in_survey_path
value: '{{inputs.parameters.add_date_in_survey_path}}'
- name: source
value: '{{inputs.parameters.source}}'
```
Expand Down
9 changes: 5 additions & 4 deletions templates/argo-tasks/generate-path.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ spec:
templateDefaults:
container:
imagePullPolicy: Always
image: ''
entrypoint: main
templates:
- name: main
Expand All @@ -19,9 +20,9 @@ spec:
description: s3 path of source data
- name: target_bucket_name
description: target bucket name e.g. 'nz-imagery'
- name: no_date_in_survey_path
description: 'If the survey path should not contain the date'
default: 'false'
- name: add_date_in_survey_path
description: 'The survey path should contain the date'
default: 'true'
- name: version
description: argo-task Container version to use
default: 'v4'
Expand All @@ -36,7 +37,7 @@ spec:
- 'generate-path'
- '--target-bucket-name'
- '{{=sprig.trim(inputs.parameters.target_bucket_name)}}'
- '--no-date-in-survey-path={{=sprig.trim(inputs.parameters.no_date_in_survey_path)}}'
- '--add-date-in-survey-path={{=sprig.trim(inputs.parameters.add_date_in_survey_path)}}'
- '{{=sprig.trim(inputs.parameters.source)}}'

outputs:
Expand Down

0 comments on commit b851ea5

Please sign in to comment.