Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --no_date_in_survey_path handling TDE-1261 #759

Merged
merged 2 commits into from
Oct 7, 2024
Merged

feat: --no_date_in_survey_path handling TDE-1261 #759

merged 2 commits into from
Oct 7, 2024

Conversation

paulfouquet
Copy link
Collaborator

Motivation

Allowing the generate-path template to use the new flag available linz/argo-tasks#1067

Modification

add a new parameter to handle the flag

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@paulfouquet paulfouquet marked this pull request as ready for review September 30, 2024 02:05
@paulfouquet paulfouquet requested review from a team as code owners September 30, 2024 02:05
@l0b0
Copy link
Contributor

l0b0 commented Sep 30, 2024

Also, I realise the parameter should've been --date-in-survey-path, to avoid double negatives.

@paulfouquet @l0b0
fix: parameter name is wrong
1718f7e 
Co-authored-by: Victor Engmark <[email protected]>
@paulfouquet paulfouquet requested a review from l0b0 October 7, 2024 20:48
@paulfouquet
Copy link
Collaborator Author

Also, I realise the parameter should've been --date-in-survey-path, to avoid double negatives.

I will handle this in separate PRs

@paulfouquet paulfouquet added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit 9584b69 Oct 7, 2024
3 checks passed
@paulfouquet paulfouquet deleted the feat/generate-path-no-date-in-survey-path-tde-1261 branch October 7, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

@blacha blacha Awaiting requested review from blacha blacha is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@Wentao-Kuang Wentao-Kuang Awaiting requested review from Wentao-Kuang Wentao-Kuang is a code owner automatically assigned from linz/proj-basemaps-dev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfouquet @l0b0