Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate rockspecs for each backend. #52

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

moteus
Copy link
Contributor

@moteus moteus commented Feb 25, 2015

This allows install only needed modules without additional deps.

@lipp
Copy link
Owner

lipp commented Feb 27, 2015

this is a very clean approach. i am hesitating though since this will releases and versioning more complicate i guess. maybe we can add some tag/release script to this PR?

@moteus
Copy link
Contributor Author

moteus commented Feb 27, 2015

maybe we can add some tag/release script to this PR?

You mean generate rockspecs?
I work on Windows so I think I can use only Lua (not bash)
Maybe somewhere there is such a tool.

@moteus
Copy link
Contributor Author

moteus commented Mar 1, 2015

I found that websocket.tools uses mime module from luasocket.
So I have two options

  1. Add luasocket in dependencies to websocket.core
  2. Use some base64 module. And check at load time which one to use (base64, basexx, luasocket).
    In this case I suggest add basexx module as dependency because it pure Lua module.

@lipp
Copy link
Owner

lipp commented Mar 5, 2015

@ntd introduced using luasocket mime here:
40a02ae

lluv changes the premises as every other (minimal) impl always required luasocket.

i'd like to re-add the base64 variant from:

local base64chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/'

so dependencies are not going wild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants