Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Uploading|RichText fields before saving #1011

Closed
kleingeist opened this issue Nov 15, 2017 · 1 comment
Closed

Clean Uploading|RichText fields before saving #1011

kleingeist opened this issue Nov 15, 2017 · 1 comment
Labels
Type: Bug incorrect or uexpected behaviour

Comments

@kleingeist
Copy link
Contributor

either change the field in core as described in liqd/adhocracy4#213
or call the clean method manually in the models save() method (see https://github.com/liqd/a4-meinberlin/blob/master/meinberlin/apps/ideas/models.py#L44 )

the following models are currently affected, as they are missing the clean call:

  • ModeratorFeedback.description
  • Newsletter.body
  • Partner.about

Also note, that the whole topicprio bug was due to the inability to redefine a RichText as an UploadingRichText Field because of the cleaning done in the models save method

@kleingeist kleingeist added the Type: Bug incorrect or uexpected behaviour label Nov 15, 2017
@kleingeist
Copy link
Contributor Author

closed with #1010
although i'd still prefer the core field solution

kleingeist pushed a commit to liqd/a4-product that referenced this issue Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug incorrect or uexpected behaviour
Projects
None yet
Development

No branches or pull requests

1 participant