extend plan model #1010
Merged
extend plan model #1010
+152
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleingeist
reviewed
Nov 15, 2017
| contact = models.TextField(max_length=255, verbose_name=_('Contact')) | ||
| cost = models.PositiveIntegerField(blank=True, null=True, | ||
| verbose_name=_('Cost')) | ||
| description = RichTextField(verbose_name=_('Description'), blank=True) |
There was a problem hiding this comment.
richtextfields need some additional handlin in the save method:
see https://github.com/liqd/a4-meinberlin/blob/master/meinberlin/apps/ideas/models.py#L44
this ensures forbidden html is removed from the string. i did create issue #1011 and liqd/adhocracy4#213 on that topic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds many more fields to the plans model. We are not quite sure if these fields will be in the final version. However, we definitely want to add them now so we can get better feedback from the clients.
The only field that has been omitted is "timespan" as the format is very unclear. A human readable version of that information can be included in the description for now.