-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8813] Add kiezradar delete modal #6002
Conversation
29ed879
to
ff14a4f
Compare
@@ -138,3 +177,44 @@ function EditLink ({ to }) { | |||
</Link> | |||
) | |||
} | |||
|
|||
function DeleteModal ({ onDelete, onClose }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this component in the KiezradarList
file as it wasn't used elsewhere. Can extract if that's a preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my message below
ff14a4f
to
52ea6f8
Compare
Hey @sevfurneaux, looks good, thanks! Just one thing: I recently refactored The changes aren’t merged yet: PR #1758. |
Thanks @hom3mad3! Is it ok if we merge this in, and then once the modals are completed/moved over to A4, we can retrospectively change this? The reason being, this implementation allows for #8751 [mB] Kiezradar frontend: managing Kieze on the "Ihre Kieze" ("Kieze verwalten") page (sev) to be completed, then Janek/Carolin can test the full kiezradar flow (creation, editing, deletion). |
sounds good, i will file an issue! thank you ✨ |
Describe your changes
This PR adds a delete modal for deleting kiezradars.
Tasks