Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map namespaces #6003

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix map namespaces #6003

merged 2 commits into from
Jan 30, 2025

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 29, 2025 •
edited
Loading

Describe your changes
fixes map namespace clash with react_maps
depends on a4 Pull Request: liqd/adhocracy4#1766

fixes #5999

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip mentioned this pull request Jan 29, 2025
Merged
4 tasks
@vellip vellip requested a review from goapunk January 29, 2025 15:53
goapunk
goapunk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Feel free to merge after updating a4 in a new commit

@vellip vellip merged commit 08afbae into dev Jan 30, 2025
3 checks passed
@vellip vellip deleted the pv-2025-01-fix-map-namespaces branch January 30, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vellip @goapunk