Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

translation: traditional chinese (taiwan) #918

Merged
merged 3 commits into from
Jun 17, 2014
Merged

translation: traditional chinese (taiwan) #918

merged 3 commits into from
Jun 17, 2014

Conversation

xi
Copy link
Collaborator

@xi xi commented Jun 16, 2014

This adds a chinese translation to adhocracy. Big thanks to the translator Charles Chuang!

Before adding a new language for moment.js I took the time to update it to 2.7.0.

While transifex and moment.js use the locale code zh_TW, babel claims that zh_TW is not a real locale and zh_Hant_TW should be used instead (search for "zh_TW" on http://babel.pocoo.org/docs/api/core/). This is where all the soft links are coming from.

While testing I realized that we forgot to mark up numbers for translation. I created #917 for that.

Tobias Bengfort added 2 commits June 16, 2014 12:04
While transifex and moment.js use the locale code zh_TW, babel claims
that zh_TW is not a real locale and zh_Hant_TW should be used instead
(search for "zh_TW" on http://babel.pocoo.org/docs/api/core/).

This is where all the soft links are coming from.
@xi
Copy link
Collaborator Author

xi commented Jun 16, 2014

A quick note on what I did to actually see the characters on debian:

  1. I enabled some chinese locales via dpkg-reconfigure locales
  2. installed some chinese fonts: apt-get install ttf-arphic-bkai00mp ttf-arphic-bsmi00lp ttf-arphic-gbsn00lp ttf-arphic-gbsn00lp

@xi
Copy link
Collaborator Author

xi commented Jun 16, 2014

We were not sure how chinese characters would interact with some custom font-family and font-face rules. So I did a bit of reading.

I found a helpful article about CSS fonts and simplified chinese that gave a good overview.

The important bit is that fonts are chose for each character individually which means that for chinese characters, the default fallback (sans-serif in most cases) takes precedence.

@nidico
Copy link
Collaborator

nidico commented Jun 16, 2014

Very cool!

One small thing: The translations for plural form strings are missing.

@xi
Copy link
Collaborator Author

xi commented Jun 17, 2014

The translations for plural form strings are missing.

This was a complex issue. The translations are not really missing. But the pluralization-information got lost when compiling to .mo. I created a pull request and switched to my fixed version (16b21b0) of c2c.recipe.msgfmt to fix this.

@nidico
Copy link
Collaborator

nidico commented Jun 17, 2014

Very good, thanks for the fix! Works fine, merging now.

nidico pushed a commit that referenced this pull request Jun 17, 2014
translation: traditional chinese (taiwan)
@nidico nidico merged commit b22c01e into liqd:develop Jun 17, 2014
@nidico nidico deleted the feature-i18n-zh_TW branch June 17, 2014 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants