polls: add new signal which is called after a user voted on a poll #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2024-11-user-voted-signal
branch
from
3378c06
to
7d3322c
Compare
4 tasks
m4ra
reviewed
Nov 13, 2024
| @@ -0,0 +1,3 @@ | |||
| from django.dispatch import Signal | |||
|
|
|||
| poll_voted = Signal() | |||
There was a problem hiding this comment.
Can you add here the arguments that are needed for the signal.
m4ra
reviewed
Nov 13, 2024
adhocracy4/polls/api.py
Outdated
| @@ -178,6 +179,8 @@ def vote(self, request, pk): | |||
| self.save_vote(question, vote_data, creator, content_id) | |||
|
|
|||
| poll = self.get_object() | |||
| print("##########################################") | |||
| poll_voted.send(sender=None, poll=poll, creator=creator, content_id=content_id) | |||
There was a problem hiding this comment.
sender is the poll view, I have added it as the self.__class__ in my PR for mB kiezradar.
There was a problem hiding this comment.
and the print statement can go I believe :)
m4ra
requested changes
Nov 13, 2024
adhocracy4/polls/api.py
Outdated
| @@ -178,6 +179,8 @@ def vote(self, request, pk): | |||
| self.save_vote(question, vote_data, creator, content_id) | |||
|
|
|||
| poll = self.get_object() | |||
| print("##########################################") | |||
| poll_voted.send(sender=None, poll=poll, creator=creator, content_id=content_id) | |||
There was a problem hiding this comment.
and the print statement can go I believe :)
goapunk
force-pushed
the
jd-2024-11-user-voted-signal
branch
from
7d3322c
to
fc7d8fc
Compare
m4ra
reviewed
Nov 18, 2024
goapunk
force-pushed
the
jd-2024-11-user-voted-signal
branch
from
fc7d8fc
to
a563444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks