Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Fulvio Risso <[email protected]>
  • Loading branch information
Sharathmk99 and frisso authored Sep 18, 2023
1 parent a13c0b4 commit 3b67a88
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions deployments/liqo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
| auth.pod.extraArgs | list | `[]` | Extra arguments for the auth pod. |
| auth.pod.labels | object | `{}` | Labels for the auth pod. |
| auth.pod.resources | object | `{"limits":{},"requests":{}}` | Resource requests and limits (https://kubernetes.io/docs/user-guide/compute-resources/) for the auth pod. |
| auth.service.allocateLoadBalancerNodePorts | string | `""` | If service type is LoadBalancer and want to expose the auth port on NodePorts set it to true. |
| auth.service.allocateLoadBalancerNodePorts | string | `""` | Set to false if you expose the auth service as LoadBalancer and you do not want to create also a NodePort associated to it (Note: this setting is useful only on cloud providers that support this feature). |
| auth.service.annotations | object | `{}` | Annotations for the auth service. |
| auth.service.labels | object | `{}` | Labels for the auth service. |
| auth.service.loadBalancerIP | string | `""` | Override the IP here if service type is LoadBalancer and you want to use a specific IP address, e.g., because you want a static LB. |
Expand Down Expand Up @@ -82,7 +82,7 @@
| gateway.pod.labels | object | `{}` | Labels for the network gateway pod. |
| gateway.pod.resources | object | `{"limits":{},"requests":{}}` | Resource requests and limits (https://kubernetes.io/docs/user-guide/compute-resources/) for the network gateway pod. |
| gateway.replicas | int | `1` | The number of gateway instances to run. The gateway component supports active/passive high availability. Make sure that there are enough nodes to accommodate the replicas, because such pod has to run in the host network, hence no more than one replica can be scheduled on a given node. |
| gateway.service.allocateLoadBalancerNodePorts | string | `""` | If service type is LoadBalancer and want to expose the gateway ports on NodePorts set it to true. |
| gateway.service.allocateLoadBalancerNodePorts | string | `""` | Set to false if you expose the gateway service as LoadBalancer and you do not want to create also a NodePort associated to it (Note: this setting is useful only on cloud providers that support this feature). |
| gateway.service.annotations | object | `{}` | Annotations for the network gateway service. |
| gateway.service.labels | object | `{}` | Labels for the network gateway service. |
| gateway.service.loadBalancerIP | string | `""` | Override the IP here if service type is LoadBalancer and you want to use a specific IP address, e.g., because you want a static LB. |
Expand Down
4 changes: 2 additions & 2 deletions deployments/liqo/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ gateway:
labels: {}
# -- Override the IP here if service type is LoadBalancer and you want to use a specific IP address, e.g., because you want a static LB.
loadBalancerIP: ""
# -- If service type is LoadBalancer and want to expose the gateway ports on NodePorts set it to true.
# -- Set to false if you expose the gateway service as LoadBalancer and you do not want to create also a NodePort associated to it (Note: this setting is useful only on cloud providers that support this feature).
allocateLoadBalancerNodePorts: ""
config:
# -- Override the default address where your network gateway service is available.
Expand Down Expand Up @@ -335,7 +335,7 @@ auth:
port: 443
# -- Override the IP here if service type is LoadBalancer and you want to use a specific IP address, e.g., because you want a static LB.
loadBalancerIP: ""
# -- If service type is LoadBalancer and want to expose the auth port on NodePorts set it to true.
# -- Set to false if you expose the auth service as LoadBalancer and you do not want to create also a NodePort associated to it (Note: this setting is useful only on cloud providers that support this feature).
allocateLoadBalancerNodePorts: ""
# -- Enable TLS for the Authentication Service Pod (using a self-signed certificate).
# If you are exposing this service with an Ingress, consider to disable it or add the appropriate annotations to the Ingress resource.
Expand Down

0 comments on commit 3b67a88

Please sign in to comment.