Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add external network apis #1994

Merged
merged 1 commit into from
Sep 21, 2023
Merged

add external network apis #1994

merged 1 commit into from
Sep 21, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 11, 2023

Description

This PR adds the required resources needed for the new External Network.

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli marked this pull request as ready for review September 11, 2023 10:00
@aleoli aleoli requested review from cheina97 and fra98 September 11, 2023 10:00
cheina97
cheina97 reviewed Sep 18, 2023
View reviewed changes
apis/networking/v1alpha1/connection_types.go Show resolved Hide resolved
apis/networking/v1alpha1/firewallconfiguration_types.go Show resolved Hide resolved
apis/networking/v1alpha1/gatewayclient_types.go Show resolved Hide resolved
apis/networking/v1alpha1/gatewayserver_types.go Show resolved Hide resolved
apis/networking/v1alpha1/configuration_types.go Show resolved Hide resolved
apis/networking/v1alpha1/wggatewayclienttemplate_types.go Show resolved Hide resolved
apis/networking/v1alpha1/wggatewayserver_types.go Show resolved Hide resolved
apis/networking/v1alpha1/wggatewayservertemplate_types.go Show resolved Hide resolved
apis/networking/v1alpha1/configuration_types.go Outdated Show resolved Hide resolved
apis/networking/v1alpha1/configuration_types.go Outdated Show resolved Hide resolved
@aleoli aleoli added the hold Prevent bot merging label Sep 19, 2023
@cheina97 cheina97 mentioned this pull request Sep 20, 2023
Merged
@aleoli aleoli force-pushed the aol/en-api branch 2 times, most recently from 4f8ac2f to b2879ce Compare September 21, 2023 09:26
@aleoli
Copy link
Member Author

aleoli commented Sep 21, 2023

/merge

@adamjensenbot adamjensenbot added merge-requested Request bot merging (automatically managed) and removed merge-requested Request bot merging (automatically managed) labels Sep 21, 2023
@aleoli aleoli removed the hold Prevent bot merging label Sep 21, 2023
@aleoli
Copy link
Member Author

aleoli commented Sep 21, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 21, 2023
@adamjensenbot adamjensenbot merged commit 881764f into liqotech:network-external Sep 21, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fra98 fra98 fra98 left review comments

@cheina97 cheina97 cheina97 left review comments

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleoli @adamjensenbot @cheina97 @fra98