Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDs helm subchart #2035

Merged
merged 1 commit into from
Sep 22, 2023
Merged

CRDs helm subchart #2035

merged 1 commit into from
Sep 22, 2023

Conversation

cheina97
Copy link
Member

Description

This PR creates a dedicated Helm Sub Chart for Liqo CRDS.

This avoids problems with Helm Chart Size Limitations encountered with new network API.
https://azure.github.io/azure-service-operator/design/adr-2023-02-helm-chart-size-limitations/

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 force-pushed the frc/crdsubchart branch 3 times, most recently from 742a55d to 4bff11d Compare September 20, 2023 10:56
@cheina97
Copy link
Member Author

/hold

@cheina97
Copy link
Member Author

Waiting for #1994

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Sep 20, 2023
@cheina97 cheina97 force-pushed the frc/crdsubchart branch 2 times, most recently from 402343d to 9e2d69f Compare September 21, 2023 13:52
@cheina97 cheina97 force-pushed the network-external branch 3 times, most recently from 0b3f082 to 5a75336 Compare September 21, 2023 14:05
@cheina97 cheina97 force-pushed the frc/crdsubchart branch 4 times, most recently from a595693 to d4a4834 Compare September 21, 2023 14:13
aleoli
aleoli reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@aleoli aleoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include the crd chart as a subchart of the main one.

Additionally, we should add the action to publish the chart.

deployments/liqo/charts/liqo-crds/values.yaml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 21, 2023
@cheina97
Copy link
Member Author

You should include the crd chart as a subchart of the main one.

Additionally, we should add the action to publish the chart.

The crds chart is included inside the original chart, this means that is not necessary to publish another chart

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/test

@cheina97 cheina97 merged commit a5148fb into liqotech:network-external Sep 22, 2023
@cheina97 cheina97 deleted the frc/crdsubchart branch September 22, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli left review comments

Assignees
No one assigned
Labels
hold Prevent bot merging size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli